I do that too. First write ugly code that works and then make it beautiful. Be sure not to skip that last step though 😉

Hi James,
Thanks for your reply! It’s greatly appreciated.
I agree with you on all points.
salesMan.GetOrderData(); would’ve been great too, maybe better!

Thanks! Glad you liked it 🙂

1. The var keyword was introduced to support anonymous types. I prefer not using them with defined types as it can obscure code (as it becomes unclear what type you’re working with). It’s a matter of preference though, no biggie.
2. The second code snippet has one method to retrieve the salesman, which is used in the remaining functions. In the first code snippet all functions had to retrieve the salesman (because it wasn’t passed in as an input parameter). So nope, my code isn’t out of sync with my text.
3. You’re right, we need to access the salesman, but do we need to do that in the function that also calculates the statistics? That’s what happens in the first code sample. In the second code sample there’s one function for retrieving the salesman and x functions for getting statistics (that get the salesman as input parameter).
4. I’m not talking about those three or four lines of code, I’m talking about what’s inside those functions. More specifically the part that retrieves the salesman or the data necessary to get the statistics.
5. I hope my points above made this a bit clearer for you.

Using KISS as a verb, roundtrips instead of trips, that’s just… nitpicking. Not relevant anyway.

Your final remark makes no sense. I never said multiple functions did just one thing, I said they did the same thing (so for each statistic we retrieved the salesman, huge performance hit). There aren’t any “high brow theories” and there was no trade-off. It just didn’t work and it wasn’t manageable…

Hope that clears it up.